Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP-595-sDAI-aUSDC-on-Optimism #918

Merged
merged 2 commits into from Apr 29, 2024
Merged

Conversation

Zen-Maxi
Copy link
Collaborator

Proposal: https://forum.balancer.fi/t/bip-xxx-enable-gauge-for-sdai-ausdc-pool-on-optimism/5719

Spec:
Transaction: The Balancer Maxi LM Multisig eth:0xc38c5f97B34E175FFd35407fc91a937300E33860 will interact with the GaugeAdderv4 at 0x5DbAd78818D4c8958EfF2d5b95b28385A22113Cd and call the addGauge function with the following arguments:

gauge(address): 0x9dE7f79Ef7f28447E90051b60aBC5c2b1AdFE1cf

gaugeType(string): Optimism

Simulation: https://dashboard.tenderly.co/public/safe/safe-apps/simulator/090201e0-0d47-490c-8e8d-54c77bca1bae

Proposal: https://forum.balancer.fi/t/bip-xxx-enable-gauge-for-sdai-ausdc-pool-on-optimism/5719

Spec:
Transaction: The Balancer Maxi LM Multisig eth:0xc38c5f97B34E175FFd35407fc91a937300E33860 will interact with the GaugeAdderv4 at 0x5DbAd78818D4c8958EfF2d5b95b28385A22113Cd and call the addGauge function with the following arguments:

gauge(address): 0x9dE7f79Ef7f28447E90051b60aBC5c2b1AdFE1cf

gaugeType(string): Optimism

Simulation: https://dashboard.tenderly.co/public/safe/safe-apps/simulator/090201e0-0d47-490c-8e8d-54c77bca1bae
Copy link
Contributor

BIP validation results for file BIPs/2024-W18/BIP-595 sDAI-aUSDC on Optimism.json:
Commit: 383551dbaa03bcb18dc4204ade9b78a3221ea0b3

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

Copy link
Contributor

FILENAME: BIPs/2024-W18/BIP-595 sDAI-aUSDC on Optimism.json
MULTISIG: multisigs/lm (mainnet:0xc38c5f97B34E175FFd35407fc91a937300E33860)
COMMIT: 383551dbaa03bcb18dc4204ade9b78a3221ea0b3
CHAIN(S): optimism
TENDERLY: SUCCESS

+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+---------------------------------------------------------------+------------------------------------------------+---------+------------+
| function              | pool_id_and_address                                                 | symbol_and_info          | gauge_address_and_info                     | tokens                                                        | rate_providers                                 | bip     |   tx_index |
+=======================+=====================================================================+==========================+============================================+===============================================================+================================================+=========+============+
| GaugeAdderV4/addGauge | 0x876e0a21626c33bdab879330505eccc6091aa60700020000000000000000012e  | GDSRH                    | 0x9dE7f79Ef7f28447E90051b60aBC5c2b1AdFE1cf | "sDAI(0x2218a117083f5B482B0bB821d27056Ba9c04b1D3)",           | "0x15ACEE5F73b36762Ab1a6b7C98787b8148447898",  | BIP-595 |          0 |
|                       | pool_address: 0x876E0A21626c33BDaB879330505eccc6091Aa607            | fee: 0.01, a-factor: N/A |  Style: L0 sidechain, cap: 100.0%          |   "stataOptUSDCn(0x4DD03dfD36548C840B563745e3FBeC320F37BA7e)" |   "0xdFa8d2b3c146b8a10B5d63CA0306AEa84B602cfb" |         |            |
+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+---------------------------------------------------------------+------------------------------------------------+---------+------------+

Copy link
Member

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good including rate providers

just missing core pools json addition

@Tritium-VLK
Copy link
Member

@gosuto-inzasheru we don't track/manage core pools on Optimism. BeethovenX does.

@Tritium-VLK Tritium-VLK merged commit 7abd0b2 into main Apr 29, 2024
@Tritium-VLK Tritium-VLK deleted the BIP-595-sDAI-aUSDC-on-Optimism branch April 29, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants