Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP-596: Enable weETH/WETH Gauge [BASE] #945

Merged
merged 2 commits into from
May 3, 2024
Merged

BIP-596: Enable weETH/WETH Gauge [BASE] #945

merged 2 commits into from
May 3, 2024

Conversation

Xeonus
Copy link
Collaborator

@Xeonus Xeonus commented May 1, 2024 •
edited

@Xeonus
B
9643520 
- Enable weETH:WETH gauge with 10% cap on Base
- Deployment via standard chainlink rate provider: https://basescan.org/address/0x5a7a419c59eaadec8dc00bc93ac95612e6e154cf#code
- Proposal: https://forum.balancer.fi/t/bip-596-enable-weeth-weth-gauge-w-10-cap-base/5732
- Add core pool designation
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024

BIP validation results for file BIPs/2024-W19/BIP-596.json:
Commit: 964352027a139a09eb91e5e345074794b4608fa4

+-------------------------------+--------+
|           Validator           | Result |
+-------------------------------+--------+
|     validate_contains_msig    |   OK   |
| validate_msig_in_address_book |   OK   |
|    validate_chain_specified   |   OK   |
|     validate_file_has_bip     |   OK   |
|  validate_path_has_weekly_dir |   OK   |
+-------------------------------+--------+

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024

FILENAME: BIPs/2024-W19/BIP-596.json
MULTISIG: multisigs/lm (mainnet:0xc38c5f97B34E175FFd35407fc91a937300E33860)
COMMIT: 964352027a139a09eb91e5e345074794b4608fa4
CHAIN(S): base
TENDERLY: SUCCESS

+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+------------------------------------------------------------+-------------------------------------------------+---------+------------+
| function              | pool_id_and_address                                                 | symbol_and_info          | gauge_address_and_info                     | tokens                                                     | rate_providers                                  | bip     |   tx_index |
+=======================+=====================================================================+==========================+============================================+============================================================+=================================================+=========+============+
| GaugeAdderV4/addGauge | 0xab99a3e856deb448ed99713dfce62f937e2d4d74000000000000000000000118  | weETH/wETH               | 0x2280B8C8B401CA54eBF15736B77E1d3bF4924A9D | "weETH(0x04C0599Ae5A44757c0af6F9eC3b93da8976c150A)",       | "0x5a7A419C59eAAdec8Dc00bc93ac95612e6e154Cf",   | BIP-596 |          0 |
|                       | pool_address: 0xaB99a3e856dEb448eD99713dfce62F937E2d4D74            | fee: 0.04, a-factor: 600 |  Style: L0 sidechain, cap: 100.0%          |   "WETH(0x4200000000000000000000000000000000000006)",      |   "0x0000000000000000000000000000000000000000", |         |            |
|                       |                                                                     |                          |                                            |   "weETH/wETH(0xaB99a3e856dEb448eD99713dfce62F937E2d4D74)" |   "0x0000000000000000000000000000000000000000"  |         |            |
+-----------------------+---------------------------------------------------------------------+--------------------------+--------------------------------------------+------------------------------------------------------------+-------------------------------------------------+---------+------------+

@Xeonus Xeonus changed the title BIP-596: Enable weETH/WETH Gauge w/ 10% cap [BASE] BIP-596: Enable weETH/WETH Gauge [BASE] May 1, 2024
gosuto-inzasheru
gosuto-inzasheru approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rate provider is deployed through the usual cl factory

@Tritium-VLK Tritium-VLK merged commit 5ce4ce4 into main May 3, 2024
@Tritium-VLK Tritium-VLK deleted the BIP-596-enable-weETH-WETH-gauge-base branch May 3, 2024 17:20
ReClicker
ReClicker reviewed May 5, 2024
View reviewed changes
Copy link

@ReClicker ReClicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thankful for you

ReClicker
ReClicker reviewed May 5, 2024
View reviewed changes
Copy link

@ReClicker ReClicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thankful for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReClicker ReClicker ReClicker left review comments

@gosuto-inzasheru gosuto-inzasheru gosuto-inzasheru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Xeonus @gosuto-inzasheru @ReClicker @Tritium-VLK