Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added features to request version and license informations #142

Closed
wants to merge 48 commits into from
Closed

added features to request version and license informations #142

wants to merge 48 commits into from

Conversation

bb-Ricardo
Copy link
Contributor

added two new features to last PR:

  • request licenses informations of ESXi hosts and vCenter
  • request ESXi and vCenter VMWare version

lazyfrosch and others added 30 commits July 31, 2015 11:37
Only a lock file is used when actually updating the session, which happens when:

  * there is no session file
  * the session is no longer valid

Parallel jobs will try to use the old session, if that fails every process will
re-login, but the session file will only be written once. The scripts checks if
the session file has been changed since their own program start time.
This allows Github to render Markdown.
This allows the plugin to run on any distribution in a yet better way.
…erience

- Add About section which explains the purpose of this plugin
- Explain two installation modes
- Move specific explanations into FAQ chapter
- Add a note on VMware API timeouts
- Add some examples and references to Icinga 2 configuration and CheckCommands
- Add chapters similar to known Icinga projects
- Reformat everything as proper Markdown
otherwise cookies may not match with LWP
$host_state cannot equal to UP and "Maintenance Mode"
at the same time
Compare the api returned url and the given url2connect less error prone.
Using --sslport=443 results in a url2connect https://vcenter:443/... while
get_option returns https://vcenter/...
Also it seems like some api returns .../sdk while others return .../sdk/webService
so just ignore that part.
Both leads to not resuing the existing session files.

this should fix #115
Use Perl from env instead of a fixed path
Instead of calling Vim::get_view for each datastore call
Vim::get_views with all of them at once.
only write warning if host runtime is checked with no subselect
merge recent additions to master
Sometimes not all hardware components are correctly reported via
CIM interface which leads to check errors when checking runtime
status all. This option ignores the health status and prevents the
the plugin from failing to report the overall status of the host.
IMPORTENT: make sure to monitor the host health status separately!
Most likely via ILO/ILOM interface.
Also command_reference has been updated
Missing history entry in check_vmware_esx.pl from last comit added
@bb-Ricardo bb-Ricardo changed the title Next release added features to request version and license informations Nov 9, 2018
@BaldMansMojo
Copy link
Owner

Hi,
downloaded your file but I have to merge them manually due to the fact that I've done several changes. But in general: When I reworked the code from op5 I removed all informations not necessary for monitoring and alerting. This is more kind of reporting and I'm quite unsure if I should add it or not. I think it would be better to do via Vcenter (or am I on the "woodway"?

So give me a feedback why I should add it. Maybe there is something useful I haven't thought about. For now I will close this request but I have the code to implement it.

Martin

@bb-Ricardo
Copy link
Contributor Author

Hi,

well it's about if you licensed your environment properly or not.

2 examples:

  • you running a ESXi at home and don't have a vcenter, then it would be great to know when the evaluation licenses runs out
  • you have a big environment with hundreds of ESXi host and want to make sure they all use the ame licenses or someone forgot to enter the license while setup.

And I wanted to reduce the amount of esxi icinga plugins to use for monitoring.

@BaldMansMojo
Copy link
Owner

Ok - that's an argument. I will implement this evening.

@BaldMansMojo
Copy link
Owner

I will add as much as possible this weekend because I will have a presentation next Monday about monitoring VMware next Monday on Monitoring Workshop here in Munich.

@bb-Ricardo
Copy link
Contributor Author

I will prepare another pull request this afternoon

@BaldMansMojo
Copy link
Owner

About what? Only to know that we won't run in conficts.

Regards
Martin

@bb-Ricardo
Copy link
Contributor Author

This feauture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants