Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak in console.re on 1.1.x #54

Open
Baldhor opened this issue Oct 10, 2023 · 4 comments
Open

Memory leak in console.re on 1.1.x #54

Baldhor opened this issue Oct 10, 2023 · 4 comments
Assignees
@Baldhor
Labels
bug Something isn't working low priority Low Priority

Comments

@Baldhor
Copy link
Owner

Baldhor commented Oct 10, 2023

obviously, version 1.1.x introduced a new memory leak:
image
@Baldhor Baldhor changed the title Mémory leak Memory leak Oct 10, 2023
@Baldhor Baldhor changed the title Memory leak Memory leak on 1.1.x Oct 10, 2023
@Baldhor Baldhor self-assigned this Oct 10, 2023
@Baldhor Baldhor added the bug Something isn't working label Oct 10, 2023
Baldhor added a commit that referenced this issue Oct 10, 2023
@Baldhor
Bump version to v1.1.7
76602b7 
Changelog: Fixed #54 and #44: Now, you can collect debug logs directly from the page Manage your physical devices
@Baldhor Baldhor reopened this Oct 11, 2023
@Baldhor
Copy link
Owner Author

Baldhor commented Oct 11, 2023

Still not solved, I turned off console.re around 1am, and as we can see on this graphic, the memory leak immediatly stopped.

image

Obviosuly, the problem come from console.re implementation, but I have no idea where ...
It's not a priority, usage of console.re is not anymore so much required with the new "collect debug info" functionnality.

@RoadXY
Copy link
Collaborator

RoadXY commented Oct 11, 2023

Or have the driver disable it after a set amount of time, like 2 hours?

@Baldhor Baldhor added the low priority Low Priority label Oct 12, 2023
@Baldhor Baldhor changed the title Memory leak on 1.1.x Memory leak in console.re on 1.1.x Oct 12, 2023
@Baldhor
Copy link
Owner Author

Baldhor commented Oct 12, 2023 •
edited
Loading

Or have the driver disable it after a set amount of time, like 2 hours?

auto-disable has a 2 days period, in latest version, it is 6 hours.
Seems we had the same idea :)

@RoadXY
Copy link
Collaborator

RoadXY commented Oct 13, 2023

That's a problem for later. Solved for now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Baldhor Baldhor

Labels
bug Something isn't working low priority Low Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RoadXY @Baldhor