closes #412. Check queue size to subscribe_packet_data

BallAerospace · Mar 28, 2017 · 20c31ed · 20c31ed
1 parent 5020c5d
commit 20c31ed
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/lib/cosmos/tools/cmd_tlm_server/cmd_tlm_server.rb b/lib/cosmos/tools/cmd_tlm_server/cmd_tlm_server.rb
@@ -431,6 +431,10 @@ def self.subscribe_packet_data(packets,
         raise ArgumentError, "packets must be nested array: [['TGT','PKT'],...]"
       end
 
+      unless queue_size.is_a? Integer and queue_size > 0
+        raise ArgumentError, "Invalid queue size for subscribe_packet_data: #{queue_size}"
+      end
+
       id = nil
       upcase_packets = []
 

diff --git a/spec/tools/cmd_tlm_server/cmd_tlm_server_spec.rb b/spec/tools/cmd_tlm_server/cmd_tlm_server_spec.rb
@@ -269,6 +269,10 @@ module Cosmos
     end
 
     describe "self.subscribe_packet_data" do
+      it "rejects bad queue sizes" do
+        expect{ CmdTlmServer.subscribe_packet_data([["COSMOS","VERSION"]], true) }.to raise_error(ArgumentError)
+      end
+
       it "subscribes to packets" do
         version = System.telemetry.packet("COSMOS","VERSION")
         allow_any_instance_of(Interface).to receive(:read) do