Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIN MAX for command params closes #190 #290

Merged
merged 3 commits into from May 5, 2016
Merged

MIN MAX for command params closes #190 #290

merged 3 commits into from May 5, 2016

Conversation

jmthomas
Copy link
Contributor

@jmthomas jmthomas commented May 3, 2016

No description provided.

@coveralls
Copy link

coveralls commented May 3, 2016 •
edited

Coverage Status

Coverage increased (+0.006%) to 85.578% when pulling abc88c7 on simple_min_max_cmd_def into 762eb71 on master.

@ghost
Copy link

ghost commented May 3, 2016

We should update handle_defined_constants to handle any size INT/UINT

@jmthomas
Copy link
Contributor Author

jmthomas commented May 4, 2016

Grrr, you're right of course but my fix was so simple!

@jmthomas
Copy link
Contributor Author

jmthomas commented May 4, 2016

I didn't add the logic in handle_defined_constants because it would require passing in the type and bit size. I think we could potentially deprecate all the previous constants in favor of just MIN/MAX in the future.

@coveralls
Copy link

coveralls commented May 4, 2016 •
edited

Coverage Status

Coverage decreased (-0.03%) to 85.544% when pulling c393f15 on simple_min_max_cmd_def into 762eb71 on master.

@coveralls
Copy link

coveralls commented May 5, 2016 •
edited

Coverage Status

Coverage decreased (-0.05%) to 85.518% when pulling 59595e4 on simple_min_max_cmd_def into 762eb71 on master.

@jmthomas
Copy link
Contributor Author

jmthomas commented May 5, 2016

@ryanatball check out my latest commit

@ghost
Copy link

ghost commented May 5, 2016

Looks good. 👍

@jmthomas jmthomas merged commit 3afa018 into master May 5, 2016
@jmthomas jmthomas deleted the simple_min_max_cmd_def branch January 13, 2017 16:44
ghost pushed a commit that referenced this pull request Jan 27, 2022
@GerhardOfRivia
Pull request #290: Update copyright year
7ac2c7d 
Merge in COSMOSEE/base from copyright-year-2022-update to master

Squashed commit of the following:

commit 9f2ab26444488e488623233881dd166625dad852
Author: van Andel, Gerhard <gvanande@ball.com>
Date:   Wed Jan 26 16:35:28 2022 -0700

    Update copyright year
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmthomas @coveralls