Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #57 Add OPTION keyword for interfaces and routers #58

Merged
1 commit merged into from Feb 17, 2015

Conversation

ghost
Copy link

@ghost ghost commented Feb 16, 2015

@jmthomas Please Review

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 91.05% when pulling d50345c on add-option-keyword-for-interfaces into f4070ee on master.

@jmthomas
Copy link
Contributor

So it looks like you built in support for LISTEN_ADDRESS into tcpip_server_interface.rb but that this could be used for anything in the future and for custom interfaces.
👍

@ghost
Copy link
Author

ghost commented Feb 17, 2015

Yep. This allows us to add features to existing interfaces without breaking the API. Also provides a nice way to give parameters to interfaces without having really long single lines.

ghost pushed a commit that referenced this pull request Feb 17, 2015
…rfaces

closes #57 Add OPTION keyword for interfaces and routers
@ghost ghost merged commit 00459e3 into master Feb 17, 2015
@ghost ghost deleted the add-option-keyword-for-interfaces branch February 17, 2015 17:09
@jmthomas
Copy link
Contributor

You know how I hate those really long single lines! 😃

ghost pushed a commit that referenced this pull request Apr 5, 2021
Merge in COSMOSEE/base from fix_traefik_static to master

* commit 'da1d7bf8964e7bda748d913a61626b34a579a816':
  improve commenting
  fix traefik static
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants