Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Action menu to create target. Allow delete from file tree #667

Merged
1 commit merged into from Nov 30, 2017

Conversation

ghost
Copy link

@ghost ghost commented Nov 21, 2017

closes #666

@ghost ghost requested review from a user and donaldatball November 21, 2017 21:19
@ghost
Copy link
Author

ghost commented Nov 21, 2017

This also allows delete but sometimes I get a "QFileSystemWatcher: FindNextChangeNotification failed!! (Access is denied.)" printed. I'm not sure how to catch that and either ignore it or warn the user. It seems like sometimes the delete DOES happen even if Qt says it didn't.

@ghost
Copy link
Author

ghost commented Nov 21, 2017

Let me know what you think of the file structure I create with a new target. I wanted to give an example of a target library and target procedure which used the library as I think this is something not a lot of people know how to do.

@ghost
Copy link

ghost commented Nov 30, 2017

👍 All looks good

@ghost ghost merged commit b34184f into master Nov 30, 2017
@ghost ghost deleted the config_editor_create_target branch November 30, 2017 19:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to create target to ConfigEditor
1 participant