Cloning an instrument permanently disable creating a new instrument

[Pigu-A]

No description provided.

[rerrahkr]

Thanks for your report.
Does it happen when you have many instruments in the instrument list? Up to 127 instruments can be added to the list, and the tracker ignores instrument addition and cloning when the list is filled.

If your report doesn't match this, that is an unknown bug, could you please elaborate the situation where the problem occurred?

[nyanpasu64]

The description of the bug is inaccurate.

• In the pattern editor, highlight a rhythm channel.
• Focus a different instrument in the instrument list.

There are many ways to focus a different instrument:

• Left-click or right-click another instrument.
• Delete an instrument so focus moves to another instrument.
• Clone the current instrument, then left-click the copy. Actually cloning is unrelated to the bug.

The Add Instrument button is disabled until you close the program. Focusing a non-rhythm channel then switching instruments doesn't re-enable the button.

I think the button should be automatically disabled as soon as you focus a rhythm channel, and automatically enabled as soon as you focus a non-rhythm channel.

BambooTracker-v0.3.5.33-dev

[pedipanol]

This also happens when importing a .PPC or .PVI sample bank Em Ter, 17 de mar de 2020 02:17, nyanpasu64 <notifications@github.com> escreveu:

…

The description of the bug is inaccurate. - In the pattern editor, highlight a rhythm channel. - Focus a different instrument in the instrument editor. There are many ways to focus a different instrument: - Left-click or right-click another instrument. - Delete an instrument so focus moves to another instrument. - Clone the current instrument, then left-click the copy. Actually cloning is unrelated to the bug. The Add Instrument button is disabled until you close the program. Focusing a non-rhythm channel then switching instruments doesn't re-enable the button. I think the button should be automatically disabled as soon as you focus a rhythm channel, and automatically enabled as soon as you focus a non-rhythm channel. BambooTracker-v0.3.5.33-dev — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#177 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGMH5XAUQFELLHLK72UVPPDRH4BWJANCNFSM4KF7NTNQ> .

[rerrahkr]

I figured out that, thank you! At 159b813, I fixed the tracker to check whether you can add a new instrument when changing the current track, that resolve this issue.