Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows|macOS|Linux|BSD] - Incompatible with RtAudio 6.0.0 #492

Closed
OPNA2608 opened this issue Jul 23, 2023 · 3 comments · Fixed by #493
Closed

[Windows|macOS|Linux|BSD] - Incompatible with RtAudio 6.0.0 #492

OPNA2608 opened this issue Jul 23, 2023 · 3 comments · Fixed by #493
Labels
bug Something isn't working

Comments

@OPNA2608
Copy link
Member

Checklist

  • I am reporting exactly 1 bug with this issue.
  • This bug hasn't already been reported.
  • This bug hasn't already been fixed in the latest development build.

Bug Description

RtAudio 6.0.0 released, among other things featuring a

  • major API changes concerning error handling ... C++ exceptions no longer used
audio/audio_stream_rtaudio.cpp: In member function 'virtual bool AudioStreamRtAudio::initialize(uint32_t, uint32_t, uint32_t, const QString&, const QString&, QString*)':
audio/audio_stream_rtaudio.cpp:82:16: error: 'RtAudioError' does not name a type; did you mean 'RtAudioErrorType'?
   82 |         catch (RtAudioError& error) {
      |                ^~~~~~~~~~~~
      |                RtAudioErrorType
audio/audio_stream_rtaudio.cpp:83:17: error: 'error' was not declared in this scope; did you mean 'perror'?
   83 |                 error.printMessage();
      |                 ^~~~~
      |                 perror

How to reproduce

  1. Have RtAudio 6.0.0
  2. Build with qmake CONFIG+=system_rtaudio or cmake -DSYSTEM_RTAUDIO=ON

System Information

  • Operating System: NixOS 23.05
  • BambooTracker Version: 0.6.1
  • Build Type: package manager
@OPNA2608 OPNA2608 added the bug Something isn't working label Jul 23, 2023
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue Jul 25, 2023
@ehaupt
audio/bambootracker: Mark broken
1ae8465 
The port is incompatible with rtaudio 6.x. The port broke after the
recent audio/rtaudio update.

The issue is known upstream and is being tracked under:

BambooTracker/BambooTracker#492

Mark port broken while either an upstream fix or workaround is found.

Notified by:	pkg-fallout
@ehaupt
Copy link
Contributor

ehaupt commented Jul 25, 2023

Thank you for tracking and reporting this. The FreeBSD port of rtaudio was recently updated which in turn broke the FreeBSD port of bambootracker.

Here is a full build log from the FreeBSD build cluster:
https://pkg-status.freebsd.org/beefy5/data/124i386-default/e5b71726cc79/logs/bambootracker-0.6.1_1.log

@OPNA2608
Copy link
Member Author

OPNA2608 commented Jul 25, 2023 •
edited

As a workaround, you can build with the vendored RtAudio checkout. Building with the system-installed one requires a flag to be added, so just removing the flag / inverting it (qmake / cmake, iirc) should be enough.

Package will be similarly broken in Nixpkgs when NixOS/nixpkgs#245075 is merged.

I'll try to find the time to look into this Soon:tm:.

@rerrahkr rerrahkr mentioned this issue Jul 31, 2023
Merged
@ehaupt
Copy link
Contributor

ehaupt commented Jul 31, 2023

@rerrahkr thank you. Could you maybe tag v0.6.2 this would help package maintainers 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update RtAudio to v6.0.0 BambooTracker/BambooTracker
2 participants
@ehaupt @OPNA2608