Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fr translation update #121

Merged
merged 6 commits into from
Apr 29, 2019
Merged

Fr translation update #121

merged 6 commits into from
Apr 29, 2019

Conversation

jpcima
Copy link
Contributor

@jpcima jpcima commented Apr 28, 2019

Update some translation texts, except the two help dialogs for now.

notify @trebmuh for translation review

BambooTracker/res/lang/bamboo_tracker_fr.ts Outdated Show resolved Hide resolved
BambooTracker/res/lang/bamboo_tracker_fr.ts Show resolved Hide resolved
BambooTracker/res/lang/bamboo_tracker_fr.ts Outdated Show resolved Hide resolved
BambooTracker/res/lang/bamboo_tracker_fr.ts Show resolved Hide resolved
BambooTracker/res/lang/bamboo_tracker_fr.ts Outdated Show resolved Hide resolved
BambooTracker/res/lang/bamboo_tracker_fr.ts Outdated Show resolved Hide resolved
BambooTracker/res/lang/bamboo_tracker_fr.ts Outdated Show resolved Hide resolved
BambooTracker/res/lang/bamboo_tracker_fr.ts Outdated Show resolved Hide resolved
BambooTracker/res/lang/bamboo_tracker_fr.ts Outdated Show resolved Hide resolved
@rerrahkr
Copy link
Member

Since I changed gui of the groove editor at 03b5fb5, could you fix its translation too? This will be the last change of gui for v0.2.0.

@jpcima
Copy link
Contributor Author

jpcima commented Apr 28, 2019

Yes I will do these as well.

I'll have to make ":" part of the translated source. For a typographic reason, I'll need to translate with a space preceding colon.
https://github.com/rerrahkr/BambooTracker/blob/03b5fb50ef364df409ed9dea2f3e998a324078e7/BambooTracker/gui/groove_settings_dialog.cpp#L143

I'll have also to think of something appropriate to translate the verb "Pad".

@jpcima
Copy link
Contributor Author

jpcima commented Apr 28, 2019

Green light for merging once @trebmuh approves with the tiny change set a272a84.

@trebmuh
Copy link
Contributor

trebmuh commented Apr 28, 2019

Go for merging!

@rerrahkr rerrahkr merged commit 0be27ce into BambooTracker:master Apr 29, 2019
@rerrahkr
Copy link
Member

Thanks for contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants