Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid memory access on main window destruction #39

Merged
merged 1 commit into from
Dec 24, 2018

Conversation

jpcima
Copy link
Contributor

@jpcima jpcima commented Dec 22, 2018

Solves bad access into freed memory when the program is closed, found by address sanitizer.
On destruction of the comstack, it triggers a slot on the main window whose ui has been freed prior.

To prevent the problem, I ensure to destroy the ui last.
I put the variable in RAII and it's working because the members destroy in reverse order.

@rerrahkr rerrahkr merged commit ce04677 into BambooTracker:master Dec 24, 2018
@rerrahkr
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants