Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CMake build option #405

Merged
merged 15 commits into from
Mar 15, 2022
Merged

Add CMake build option #405

merged 15 commits into from
Mar 15, 2022

Conversation

OPNA2608
Copy link
Member

Closes #397.

Qt5-only WIP, only tested on Linux.

OPNA2608
OPNA2608 commented Aug 20, 2021
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@OPNA2608
Copy link
Member Author

Builds & packages on MinGW Qt6 CI now.

  • Fix DirectSound API capability detection (?)
  • Migrate some Qt5 CI to CMake too?

@OPNA2608
Copy link
Member Author

  • There's no detection for DirectSound support, adding the DS enable option on CI will have to do (could set a cache variable to enable it by default but meh)
  • Leaving the Qt5 CI on the known-working QMake config is prolly better. I've tested the CMake script on x86_64-linux and x86_64-darwin and it works well enough for a local installation (revert the last commit to test via the Nix build script), haven't looked into macOS deployment

@OPNA2608 OPNA2608 marked this pull request as ready for review March 10, 2022 11:16
@OPNA2608 OPNA2608 merged commit fd91eb4 into master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] - Alternative build system options
1 participant
@OPNA2608