Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

French L10n #63

Merged
merged 4 commits into from
Feb 23, 2019
Merged

French L10n #63

merged 4 commits into from
Feb 23, 2019

Conversation

jpcima
Copy link
Contributor

@jpcima jpcima commented Feb 12, 2019

This is the 馃嚝馃嚪 translation. All strings are done, but some verification will be nice.
Expecting for @trebmuh to validate and give us the green light.

I reworked a few elements of sources.

  • "notr" where appropriate
  • I have named or renamed current toolbars, which appear in the right click context menu: Main toolbar, Secondary toolbar.

Also: please consider PR #61 to help have a working build process for most setups.

@trebmuh
Copy link
Contributor

trebmuh commented Feb 12, 2019

Pretty much all good for me. @jpcima I made a PR on your fork with a few improvements/fixes, after what, everything looks fine to me and is ready to be merged here from my POV.

@jpcima
Copy link
Contributor Author

jpcima commented Feb 13, 2019

I believe it's fine to merge at this current state, you can go ahead.

It's still been on discussion whether individual contents of the PR above are actually appropriate, and personnally I think they aren't; we can make a followup PR happen if needed.
Current state is fine, it's not necessary to put it on wait.

@trebmuh
Copy link
Contributor

trebmuh commented Feb 14, 2019

OK for merging it as is.

@rerrahkr rerrahkr merged commit 9ec367c into BambooTracker:master Feb 23, 2019
@rerrahkr
Copy link
Member

Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants