Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flashes offset and z-index #668

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Fix flashes offset and z-index #668

merged 2 commits into from
Aug 24, 2023

Conversation

rjt-rockx
Copy link
Contributor

Also fixes nav going on top of modal overlay

@rjt-rockx
Copy link
Contributor Author

Closes #666

@rjt-rockx rjt-rockx linked an issue Aug 23, 2023 that may be closed by this pull request
flash renders behind commission header #666
Closed
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 45.535%. remained the same when pulling 6047dfd on rjt/fix-flashes-offset into 0019590 on main.

@rjt-rockx rjt-rockx self-assigned this Aug 23, 2023
@rjt-rockx rjt-rockx added bug Something isn't working design design or branding related ux user experience labels Aug 23, 2023
@zkat zkat merged commit 82338ca into main Aug 24, 2023
4 checks passed
@zkat zkat deleted the rjt/fix-flashes-offset branch August 24, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rjt-rockx rjt-rockx

Labels
bug Something isn't working design design or branding related ux user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flash renders behind commission header
3 participants
@rjt-rockx @coveralls @zkat