Feature/button reaction change #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tescher
requested changes
Jun 13, 2022
tescher
requested changes
Jun 15, 2022
| let errorContent = e.message; | ||
| if (e instanceof NotificationPermissionError) { | ||
| return ErrorUtils.sendToDefaultChannel(e.message, request); | ||
| } else if (e instanceof ValidationError) { |
There was a problem hiding this comment.
Validation and Authorization errors are now failing silently. Need to add back the error messages to the user.
There was a problem hiding this comment.
No, check line 234, 235
There was a problem hiding this comment.
Huh, I could swear it was failing with no messages for me. Now it working. OK, good
src/app/requests/RefreshRequest.ts
Outdated
| }) { | ||
| if (args.commandContext) { | ||
| if (args.commandContext.subcommands[0] !== Activities.apply) { | ||
| throw new Error('ApplyRequest attempted created for non Apply activity.'); |
tescher
reviewed
Jun 17, 2022
| let errorContent = e.message; | ||
| if (e instanceof NotificationPermissionError) { | ||
| return ErrorUtils.sendToDefaultChannel(e.message, request); | ||
| } else if (e instanceof ValidationError) { |
There was a problem hiding this comment.
Huh, I could swear it was failing with no messages for me. Now it working. OK, good
tescher
approved these changes
Jun 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.