Disabled All Campaign Behaviors

[garrettluskey]

PR Checklist

Please check if your PR fulfills the following requirements:
Tests and comments are not needed as these will be removed in the future

N/A All new classes have class-level documentation comments, if there are any at all
N/A Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation update
• Other... Please describe:

What is the current behaviour?

Any campaign functionality currently makes is harder to incrementally develop.

What is the new behaviour?

Resolves #639

The removes all campaign behaviors functionality to make incremental development easier.

Other information

[masesk]

I think this approach needs to be looked over.
It seems like MB uses CampaignEvents every time for all events. In fact, you are always catching the RegisterEvents() method.
Why not just undo those?
And if you want to get some behavior added later, just call the RegisterEvents() method on that behavior.
Saves you from adding a file for each patch.

Here is how to undo all the work by RegisterEvents()

        public override void OnAfterGameInitializationFinished(Game game, object initializerObject)
        {

            CampaignGameStarter campaignGameStarter = initializerObject as CampaignGameStarter;
            foreach (object b in campaignGameStarter.CampaignBehaviors.ToMBList())
            {
                InformationManager.DisplayMessage(new InformationMessage("Here"));

                var property = typeof(CampaignEvents).GetProperty("Instance", BindingFlags.NonPublic
                    | BindingFlags.Static);
                var instance = property.GetValue(null);
                MethodInfo methodInfo = instance.GetType()
                               .GetMethod("RemoveListeners", BindingFlags.Public | BindingFlags.Instance);
                methodInfo.Invoke(instance, new object[] { b });
            }
            

        }

[garrettluskey]

I think this approach needs to be looked over. It seems like MB uses CampaignEvents every time for all events. In fact, you are always catching the RegisterEvents() method. Why not just undo those? And if you want to get some behavior added later, just call the RegisterEvents() method on that behavior. Saves you from adding a file for each patch.

Here is how to undo all the work by RegisterEvents()

        public override void OnAfterGameInitializationFinished(Game game, object initializerObject)
        {

            CampaignGameStarter campaignGameStarter = initializerObject as CampaignGameStarter;
            foreach (object b in campaignGameStarter.CampaignBehaviors.ToMBList())
            {
                InformationManager.DisplayMessage(new InformationMessage("Here"));

                var property = typeof(CampaignEvents).GetProperty("Instance", BindingFlags.NonPublic
                    | BindingFlags.Static);
                var instance = property.GetValue(null);
                MethodInfo methodInfo = instance.GetType()
                               .GetMethod("RemoveListeners", BindingFlags.Public | BindingFlags.Instance);
                methodInfo.Invoke(instance, new object[] { b });
            }
            

        }

These patches are meant to be removed during the sync development of a given section. It sections the work nicely

[masesk]

I think this approach needs to be looked over. It seems like MB uses CampaignEvents every time for all events. In fact, you are always catching the RegisterEvents() method. Why not just undo those? And if you want to get some behavior added later, just call the RegisterEvents() method on that behavior. Saves you from adding a file for each patch.
Here is how to undo all the work by RegisterEvents()

        public override void OnAfterGameInitializationFinished(Game game, object initializerObject)
        {

            CampaignGameStarter campaignGameStarter = initializerObject as CampaignGameStarter;
            foreach (object b in campaignGameStarter.CampaignBehaviors.ToMBList())
            {
                InformationManager.DisplayMessage(new InformationMessage("Here"));

                var property = typeof(CampaignEvents).GetProperty("Instance", BindingFlags.NonPublic
                    | BindingFlags.Static);
                var instance = property.GetValue(null);
                MethodInfo methodInfo = instance.GetType()
                               .GetMethod("RemoveListeners", BindingFlags.Public | BindingFlags.Instance);
                methodInfo.Invoke(instance, new object[] { b });
            }
            

        }

These patches are meant to be removed during the sync development of a given section. It sections the work nicely

Not sure what you mean by the patches will be removed.
If the idea is to have a different event for a specific behavior (say trigger a network call for an event), you can simply add that to the CampaignEvents and pass your behavior (custom or otherwise) to it.