Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message Broker Publish Task #646

Merged
merged 2 commits into from
Jul 2, 2023
Merged

Conversation

garrettluskey
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • All new classes have class-level documentation comments, if there are any at all
  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation update
  • Other... Please describe:

What is the current behaviour?

Message broker publish runs asynchronously and has no way of being awaited.

What is the new behaviour?

This adds the functionality to be able to await the publish events

Other information

@garrettluskey garrettluskey self-assigned this Jul 2, 2023
@garrettluskey garrettluskey merged commit dad0b43 into development Jul 2, 2023
1 check passed
@garrettluskey garrettluskey deleted the message-broker-returns-task branch July 2, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants