Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero fields #791

Merged
merged 15 commits into from
Mar 30, 2024
Merged

Hero fields #791

merged 15 commits into from
Mar 30, 2024

Conversation

EgardA
Copy link
Contributor

@EgardA EgardA commented Mar 21, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • All new classes have class-level documentation comments, if there are any at all
  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation update
  • Other... Please describe:

What is the current behaviour?

No Hero Fields syncing

What is the new behaviour?

Resolves #788

Hero Fields syncing

Other information

@EgardA EgardA self-assigned this Mar 21, 2024
{
private static readonly ILogger Logger = LogManager.GetLogger<HeroFieldPatches>();

private static IEnumerable<MethodBase> TargetMethods()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the following methods for Culture

HeroDeveloper.CreateRelativeNotableHero
HeroDeveloper.DeliverOffSpring

@garrettluskey garrettluskey merged commit 148a661 into development Mar 30, 2024
1 check passed
@garrettluskey garrettluskey deleted the heroFields branch March 30, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync Hero Fields
2 participants