Add typescript friendly mixins #85
Conversation
jrobinson01
requested review from
ChadKillingsworth,
barronhagerman,
jivewise and
chrisgubbels
as code owners
| // routeExit(currentNode: RouteTreeNode, nextNode: RouteTreeNode | undefined, routeId: string, context: Context): Promise<boolean | void>; | ||
| // } | ||
|
|
||
| function animatedRoutingMixin<T extends Constructor<LitElement>>(Superclass:T, className:string) { |
There was a problem hiding this comment.
Should this be specific to LitElement?
| function animatedRoutingMixin<T extends Constructor<LitElement>>(Superclass:T, className:string) { | |
| function animatedRoutingMixin<T extends Constructor<HTMLElement>>(Superclass:T, className:string) { |
There was a problem hiding this comment.
I would think so, but there are some downstream (platform-tools) components that extend this mixin that complain when using LitElement HTMLElement. I know it's not ideal to be restricted to LitElement, but I don't believe that we'll be using any other library for the foreseeable future.
There was a problem hiding this comment.
i commented below but without the LitElement as the extended class, it causes typescript errors when using the lifecycle methods. @barronhagerman @jrobinson01
| routeEnter(currentNode: RouteTreeNode, nextNodeIfExists: RouteTreeNode | undefined, routeId: string, context: Context): Promise<boolean | void>; | ||
| routeExit(currentNode: RouteTreeNode, nextNode: RouteTreeNode | undefined, routeId: string, context: Context): Promise<boolean | void>; | ||
| } | ||
| const RoutingMixin = <T extends Constructor<LitElement>>(superclass: T) => { |
There was a problem hiding this comment.
Same here. Should this be specific to LitElement?
| const RoutingMixin = <T extends Constructor<LitElement>>(superclass: T) => { | |
| const RoutingMixin = <T extends Constructor<HTMLElement>>(superclass: T) => { |
There was a problem hiding this comment.
This was something we discovered in origin. If we don't use LitElement as the super class we get linter errors when using the lifecycle methods like connectedCallback etc
https://lit.dev/docs/composition/mixins/#mixins-in-typescript
|
|
adds typescript ports of the routing mixins:
routing.mixin.ts and animated-routing.mixin.ts
This PR also includes the built .js versions of those files. These might play nicer with projects that are not using typescript, but are using tsc and jsdoc. This PR should not affect projects using closure compiler.