Optional prefix #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to specify prefix for generated files and preprocessor definitions.
To specify prefix, set
VERSION_PREFIXcmake variable, before invokingfind_package(Version.cmake).The idea for prefixing the generated files comes from project utilizing Zephyr RTOS. When one needs to include external library, the external library targets need to be linked with target
zephyr_interface, special target which propagates compilation flags from Zephyr, but also adds a lot of paths to target include dirs. One such file isversion.h, generated by Zephyr kernel build process, which is in 'conflict' withVersion.cmake'sVersion.h. Although this was one specific problem (which may somehow be resolved by changing include dirs order), I think it is a good addition.Prefixing of the preprocessor definitions may also address #3.