Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for nonzero values in check_guest_interruptibility_state_sti_mov_ss #227

Closed
connojd opened this issue Sep 29, 2016 · 4 comments
Closed

Check for nonzero values in check_guest_interruptibility_state_sti_mov_ss #227

connojd opened this issue Sep 29, 2016 · 4 comments
Assignees
@connojd
Labels
Type: Bug

Comments

@connojd
Copy link
Member

connojd commented Sep 29, 2016

We need to check

if (sti && mov_ss)
    throw ...

rather than

if (sti == 1 && mov_ss == 1)
    throw ...

since for that check we just care about whether the individual bits are set or not.
@rianquinn
Copy link
Member

Wouldn't it then be:

if (!sti || !mov_ss)
    throw ...

@connojd
Copy link
Member Author

connojd commented Sep 29, 2016

The check fails when they're both set

@rianquinn
Copy link
Member

I see it now. Ok... sounds good.

@connojd connojd mentioned this issue Sep 30, 2016
Closed
connojd pushed a commit to connojd/hypervisor that referenced this issue Sep 30, 2016
Add fixes and tests for vmcs guest checks
20ddca2 
This commit fixes
    issue Bareflank#214
    issue Bareflank#216
    issue Bareflank#217
    issue Bareflank#218
    issue Bareflank#219
    issue Bareflank#223
    issue Bareflank#224
    issue Bareflank#225
    issue Bareflank#226
    issue Bareflank#227
    issue Bareflank#228
    issue Bareflank#229
connojd pushed a commit to connojd/hypervisor that referenced this issue Oct 1, 2016
Add fixes and tests for vmcs guest checks
23005ac 
This commit fixes issues
    Bareflank#214, Bareflank#216, Bareflank#217, Bareflank#218, Bareflank#219, Bareflank#223, Bareflank#224, Bareflank#225,
    Bareflank#226, Bareflank#227, Bareflank#228, Bareflank#229, Bareflank#230, Bareflank#232, Bareflank#234
connojd pushed a commit to connojd/hypervisor that referenced this issue Oct 5, 2016
Add fixes and tests for vmcs guest checks
5b7954c 
This commit fixes issues
    Bareflank#214, Bareflank#216, Bareflank#217, Bareflank#218, Bareflank#219, Bareflank#223, Bareflank#224, Bareflank#225,
    Bareflank#226, Bareflank#227, Bareflank#228, Bareflank#229, Bareflank#230, Bareflank#232, Bareflank#234
connojd pushed a commit to connojd/hypervisor that referenced this issue Oct 5, 2016
Add fixes and tests for vmcs guest checks
3ebb254 
 This commit fixes issues Bareflank#214, Bareflank#216, Bareflank#217, Bareflank#218, Bareflank#219,
 Bareflank#223, Bareflank#224, Bareflank#225, Bareflank#226, Bareflank#227, Bareflank#228, Bareflank#229, Bareflank#230, Bareflank#232,
 Bareflank#234, and Bareflank#236.

 There are five new guest checks implemented:

 check_guest_verify_load_ia32_bndcfgs
 check_guest_interruptibility_state_enclave_interrupt
 check_guest_pending_debug_exceptions_rtm
 check_guest_valid_pdpte_with_ept_disabled
 check_guest_valid_pdpte_with_ept_enabled
connojd pushed a commit to connojd/hypervisor that referenced this issue Oct 5, 2016
Add fixes and tests for vmcs guest checks
35d4105 
 This commit fixes issues Bareflank#214, Bareflank#216, Bareflank#217, Bareflank#218, Bareflank#219,
 Bareflank#223, Bareflank#224, Bareflank#225, Bareflank#226, Bareflank#227, Bareflank#228, Bareflank#229, Bareflank#230, Bareflank#232,
 Bareflank#234, and Bareflank#236.

 There are five new guest checks implemented:

 check_guest_verify_load_ia32_bndcfgs
 check_guest_interruptibility_state_enclave_interrupt
 check_guest_pending_debug_exceptions_rtm
 check_guest_valid_pdpte_with_ept_disabled
 check_guest_valid_pdpte_with_ept_enabled
@rianquinn rianquinn added this to the Bareflank Version 1.1 milestone Oct 6, 2016
connojd pushed a commit to connojd/hypervisor that referenced this issue Nov 23, 2016
Migrate vmcs checks
a705e85 
- The vmcs check functions are implemented in the vmcs::check
  namespace. Issues Bareflank#214, Bareflank#216, Bareflank#217, Bareflank#218, Bareflank#219, Bareflank#223, Bareflank#224,
  Bareflank#225, Bareflank#226, Bareflank#227, Bareflank#228, Bareflank#229, Bareflank#230, Bareflank#232, Bareflank#234, and Bareflank#236
  are fixed in this commit.
connojd pushed a commit to connojd/hypervisor that referenced this issue Nov 23, 2016
Migrate vmcs checks
5a37905 
- The vmcs check functions are implemented in the vmcs::check
  namespace. Issues Bareflank#214, Bareflank#216, Bareflank#217, Bareflank#218, Bareflank#219, Bareflank#223, Bareflank#224,
  Bareflank#225, Bareflank#226, Bareflank#227, Bareflank#228, Bareflank#229, Bareflank#230, Bareflank#232, Bareflank#234, and Bareflank#236
  are fixed in this commit.
@connojd connojd mentioned this issue Nov 23, 2016
Merged
@connojd
Copy link
Member Author

connojd commented Nov 23, 2016

Fixed in #343

@connojd connojd closed this as completed Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connojd connojd

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rianquinn @connojd