Test vmlaunch failure #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| vmcs_vm_instruction_error_read_count++; | ||
|
|
||
| if (vmcs_vm_instruction_error_read_count == 2) |
There was a problem hiding this comment.
This is really over-specified.... would love to see an alternative to this. Specifically, if the implementation changes, this unit test will fail even if the code is still valid.
- The case where vmlaunch fails and the checks inside the "if" branch of vmcs_intel_x64::launch all succeed is tested with this commit. - Remove unused static vmwrite, write_msr functions and add tests in order to get full coverage in vmcs_intel_x64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch tests a vmlaunch failure and ensures all checks pass in the vmcs launch function. Also, tests were added to reach full coverage of vmcs_intel_x64.cpp