Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access-control-allow-origin settings are too lose by default #118

Closed
lukeromanowicz opened this issue Mar 6, 2023 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@lukeromanowicz
Copy link

lukeromanowicz commented Mar 6, 2023

Version

nuxt-security: 0.11.0
nuxt: 3.2.3

Reproduction Link

nuxt-security.vercel.app

Steps to reproduce

image

What is Expected?

The module gives me full security out of the box.

a) Don't set this header at all leaving the default browser behavior
or
b) Require the user to set this value or at least throw warnings when it's not set

What is actually happening?

image

@lukeromanowicz lukeromanowicz added the bug Something isn't working label Mar 6, 2023
@Baroshem
Copy link
Owner

Baroshem commented Mar 6, 2023

Hey Lukasz,

The website you linked is the documentation website of the module and does not use the nuxt-security module.

What you see is the default behavior of Nuxt and H3 http engine that sets the Allow Origins header by default.

@Baroshem
Copy link
Owner

Baroshem commented Mar 6, 2023

The documentation website just shows how to use the module but does not use it as having these Security middlewares are not necessary for static Markdown website ;)

@lukeromanowicz
Copy link
Author

lukeromanowicz commented Mar 6, 2023

I see, makes sense. I made an assumption that it's not only docs but also a demo. In this case please consider this task as a feature request instead of a bug, since this default behavior is still insecure :(

Baroshem added a commit that referenced this issue Mar 6, 2023
Baroshem added a commit that referenced this issue Mar 7, 2023
@Baroshem
Copy link
Owner

Baroshem commented Mar 7, 2023

This will be released with upcoming 0.12.0 version

@Baroshem
Copy link
Owner

Baroshem commented Mar 9, 2023

@Baroshem Baroshem closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants