Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(types): do not overwrite @nuxt/schema #320

Merged
merged 2 commits into from Dec 7, 2023
Merged

Fix(types): do not overwrite @nuxt/schema #320

merged 2 commits into from Dec 7, 2023

Conversation

vejja
Copy link
Collaborator

@vejja vejja commented Dec 7, 2023

Fixes #319

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Extend interface nuxt/schema instead of @nuxt/schema to avoid overwritting type declarations of other modules.
The regression was introduced in rc5

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@vercel Vercel
Copy link

vercel bot commented Dec 7, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-security ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 3:54pm

@vejja vejja linked an issue Dec 7, 2023 that may be closed by this pull request
declare module '@nuxt/schema' breaks RuntimeConfig's type determination. #319
Closed
@vejja vejja mentioned this pull request Dec 7, 2023
Closed
@vejja vejja self-assigned this Dec 7, 2023
@vejja vejja requested a review from Baroshem December 7, 2023 15:58
@vejja vejja marked this pull request as ready for review December 7, 2023 15:58
@vejja vejja mentioned this pull request Dec 7, 2023
Merged
6 tasks
@Baroshem
Copy link
Owner

Baroshem commented Dec 7, 2023

Thanks for that! 🚀

@Baroshem Baroshem merged commit 95a9526 into chore/1.0.0 Dec 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baroshem Baroshem Awaiting requested review from Baroshem

Assignees

@vejja vejja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

declare module '@nuxt/schema' breaks RuntimeConfig's type determination.
2 participants
@vejja @Baroshem