fix: csp false in rc5 removes custom csp header #322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #321
Types of changes
Description
This PR reverts a breaking change introduced by rc.5
Previously to rc.5, setting a security header value to
false
did not modify the existing header value.With rc.5, setting a security header value to false removed the header.
We are reverting to pre-rc.5 behaviour, i.e. we semantically translate
false
todo not set
instead ofdo not send
.Checklist: