Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD favicon fix #332 #345

Merged
merged 1 commit into from Jan 17, 2024
Merged

Conversation

CMarzin
Copy link

@CMarzin CMarzin commented Jan 17, 2024

This Pull request add the nuxt-security icon into a favicon.

Types of changes

Adding only a .ico file

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #332

New favicon :
CleanShot 2024-01-17 at 10 36 47@2x

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-security ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 9:45am

@Baroshem
Copy link
Owner

Hey @CMarzin

Thanks for this PR! I have changed the base branch to 1.1.0 as I want to release it as a part of the upcoming minor release :)

@Baroshem Baroshem merged commit 805c661 into Baroshem:chore/1.1.0 Jan 17, 2024
3 checks passed
@CMarzin CMarzin deleted the feat/add-favicon branch January 18, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Favicon.ico missing
2 participants