Patch for cheerio performance #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Baroshem
approved these changes
Jan 22, 2024
|
Awesome work @vejja Let's merge it for 1.1.0 and test it there and possibly release it this week :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #341
Types of changes
Description
This is a first pass at mitigating cheerio performance issues reported in #341.
Instead of parsing and recombining multiple times the same HTML, we now parse it only once upfront, and recombine it at the end.
It is unlikely to be the best approach as we may prefer to not use Cheerio anymore and instead re-implement via regexes.
I'm proposing this patch as a quick fix in the meantime so that Cloudflare users can mitigate issues.
Checklist: