Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further optimization patch for cheerio #358

Merged
merged 1 commit into from Jan 23, 2024
Merged

Conversation

vejja
Copy link
Collaborator

@vejja vejja commented Jan 22, 2024

Fixes #341

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This is an additional patch to again improve Cheerio. Following review of Cheerio's documentation, we now

  • use the htmlparser-2 option instead of parse5
  • load the slim version of cheerio

This is the second optimization patch related to Cheerio performance issues reported in #341

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nuxt-security ✅ Ready (Inspect) Visit Preview Jan 22, 2024 1:27pm

@Baroshem Baroshem changed the base branch from main to chore/1.1.0 January 22, 2024 14:22
@Baroshem Baroshem merged commit 3847cb3 into chore/1.1.0 Jan 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance optimization opportunity
2 participants