Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-hooks): move middleware logic to beforeResponse #370

Merged
merged 3 commits into from Feb 7, 2024

Conversation

huang-julien
Copy link
Contributor

@huang-julien huang-julien commented Feb 6, 2024

fix #369

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Previously we were setting the runtime hooks configuration to the event response headers within a middleware. The issue is that this is run before the render:html hook used within 02-securityHeaders. The solution is to move all the middleware's logic to beforeResponse nitro hook

note that this is only happening for html routes

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-security ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 9:45pm

@Baroshem Baroshem merged commit 52fa75f into Baroshem:main Feb 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime Config for Security Headers
2 participants