-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 1.setup.md #473
Update 1.setup.md #473
Conversation
Provide alternative setting for development in a cleaner way.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I think that it would be better to find a solution to make DevTools work out of the box, without any additional configuration, as they are becoming omnipresent. In my opinion requiring everyone to do the same change in their configuration should be avoided and the module should resort to providing reasonable defaults instead. Still, until such a decision is made, I think that the change that I proposed enables the module's users to make a cleaner change in their configuration in order for DevTools to work. |
Hey @hermes85pl I do agree with your idea. @vejja do you think we should ship such if statement as a part of the default config? detect what is the environment and if it is dev then set a different value of the header automaically to avoid conflict with the dev tools? We could keep the devtools section with an info that in the default config it is supported but if you change it you can solve the issue like following. WDYT? |
So there would be some information that the default config for the development environment is slightly different (with the explanation what exactly and why so), and additionally how to achieve the same (using the above method) to achieve the same in case you provided your own config and the DevTools stopped working for you? Did I get it right? |
Yes, thats the idea so that majority of the users wouldnt have to set the same config in dev environment as majority of the users already use dev tools (we are anning to have some devtools integration as well once I find a time to implement it 😃) |
@vejja what are your thoughts? :) |
I think it's a good idea ! |
@hermes85pl would you be interested in creating a PR with this change where the setup of this specific header wouldnt be neede at all in dev environment? We can provide all help needed :) |
It doesn't fit in my agenda, and this is why I created this PR instead and only suggested a better idea for the final solution. How do you feel about merging this PR to change the docs like this until there is a better solution? |
I think that we should go for the solution I mentioned so that users would have a better experience out of the box. If you dont have time for developing it, no worries! I will create a PR with these changes soon :) |
Provide alternative setting for development in a cleaner way.
Types of changes
Description
Checklist: