Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support reading from websockets #476

Closed
wants to merge 12 commits into from

Conversation

GalacticHypernova
Copy link
Contributor

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This is a WIP PR to add support for reading messages from websockets, fixing #472 . It relies on the underlying socket in the connection and is therefore experimental. Due to the inability to test the module locally as stackblitz always regenerated the necessary file, I am adding this here to experiment with.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)
    Tests will arrive later

Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-security ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 11:50am

@GalacticHypernova
Copy link
Contributor Author

@Baroshem can we introduce some dependencies for some of the tests? (like websockets) Or should the module stay dependency-free?

@Baroshem
Copy link
Owner

@GalacticHypernova

Hey there! The best would be to remain deps free 🙂

@GalacticHypernova
Copy link
Contributor Author

How would we test websockets in such case? Through nitro's built in websocket system?

@GalacticHypernova
Copy link
Contributor Author

This will be refactored, the issue has been identified and is unrelated to the module, I'll open a PR in the responsible repo

@Baroshem
Copy link
Owner

Thanks for investigation @GalacticHypernova. Should we close this PR or remain as is?

@GalacticHypernova
Copy link
Contributor Author

It depends. Would you like me to make a custom data reading method to not rely on h3's?

@Baroshem
Copy link
Owner

I dont think so. We are relying in H3 so I wouldnt test any other setup

@GalacticHypernova
Copy link
Contributor Author

In that case we can close this, I forwarded the issue to h3 =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants