Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Module Options #88

Merged
merged 3 commits into from Jan 28, 2023
Merged

[Fix] Module Options #88

merged 3 commits into from Jan 28, 2023

Conversation

runyasak
Copy link
Contributor

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR is related to #87.
I've implemented options from the module setup.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@vercel
Copy link

vercel bot commented Jan 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nuxt-security ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 28, 2023 at 2:33AM (UTC)

Comment on lines +55 to +75
Or, you can pass options directly

```js{}[nuxt.config.js]
export default defineNuxtConfig({
modules: [
[
'nuxt-security',
{
requestSizeLimiter: {
value: {
maxRequestSizeInBytes: 3000000,
maxUploadFileRequestInBytes: 9000000,
},
route: '/upload-file'
}
// Other options
}
]
]
})
```
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: could you also add it to the README.md? It would be beneficial to have the same docs here and there :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I have added to README.md.
Please, review my PR again.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I approve and merge!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will release it as a part of the next release (0.11.0) in the upcoming days :)

@Baroshem Baroshem merged commit edf73f2 into Baroshem:main Jan 28, 2023
@runyasak runyasak deleted the fix/module-options branch January 28, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants