Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly specify raw format for drive to qemu_x86_64 to suppress warning #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

satnam6502
Copy link

@satnam6502 satnam6502 commented Jun 25, 2019

Currently we get the warning:

WARNING: Image format was not specified for 'hd.img' and probing guessed raw.
         Automatically detecting the format is dangerous for raw images, write operations on block 0 will be restricted.
         Specify the 'raw' format explicitly to remove the restrictions.

This PR simply adds the raw format specification to the invocation of qemu_x86_64.

    Developer's Certificate of Origin 1.1

    By making a contribution to this project, I certify that:

    (a) The contribution was created in whole or in part by me and I
        have the right to submit it under the open source license
        indicated in the file; or

    (b) The contribution is based upon previous work that, to the best
        of my knowledge, is covered under an appropriate open source
        license and I have the right under that license to submit that
        work with modifications, whether created in whole or in part
        by me, under the same open source license (unless I am
        permitted to submit under a different license), as indicated
        in the file; or

    (c) The contribution was provided directly to me by some other
        person who certified (a), (b) or (c) and I have not modified
        it.

    (d) I understand and agree that this project and the contribution
        are public and that a record of the contribution (including all
        personal information I submit with it, including my sign-off) is
        maintained indefinitely and may be redistributed consistent with
        this project or the open source license(s) involved.

    Signed-off-by: Satnam Singh <satnam@google.com>

@barrelfish-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@antiguru
Copy link
Member

Hi Satnam,
thanks for you patch. It seems past versions of qemu had raw disk as default, but that might have changed. I'd be happy to accept this change, but it shouldn't be mixed with Haskell-related changes. These need to be taken care of separately.
Moritz

@satnam6502
Copy link
Author

Good point: let me split these apart. On vacation right now, but will try to do this when I have a free moment not scoffing pintxos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants