Register TYPO3 registry as lazy service #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuingKhaos
requested changes
Mar 21, 2017
There was a problem hiding this comment.
Please reword your commit message to be a good commit message. The 63 in the beginning has no meaning in the commit log. A good commit message would be Register TYPO3 registry as lazy service
Btw. the pull request template is not for fun. You're not supposed to remove headers or sections from it. And if the syntax for fixed tickets is fixes #issuenum, not simply issuenum. The correct references are important.
Resources/config/typo3.xml
Outdated
| @@ -82,5 +82,10 @@ | |||
| <service id="typo3.page_repository" class="TYPO3\CMS\Frontend\Page\PageRepository"> | |||
| <factory service="typo3" method="getPageRepository" /> | |||
| </service> | |||
|
|
|||
| <service id="typo3.registry" class="TYPO3\CMS\Core\Registry" lazy="true"> | |||
QuingKhaos
added
in progress
and removed
enhancement
scheduled
service container
labels
QuingKhaos
changed the title
QuingKhaos
requested changes
Mar 21, 2017
|
Can please review my latest changes and eventually approve them. Thank you very much |
lzadravec
force-pushed
the
63/add-registry-service
branch
from
06ec021
to
9a59546
Compare
QuingKhaos
approved these changes
Mar 31, 2017
|
@lzadravec P.S.: For the next time, your commit message should be more clear like |
QuingKhaos
added a commit
that referenced
this pull request
Apr 3, 2017
9a59546 add typo3 registry class to services and extend documentation (Leon Zadravec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add registry service for usage in other Symfony bundles