Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom mem read #166

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Conversation

grahambates
Copy link
Contributor

I've made a change to the read-memory command in FS-UAE and WinUAE to allow reading from custom register addresses. This unblocks a few features in the debugger:

Variables pointing to addresses in this range will now correctly display their values:

image

You can read custom addresses in the Amiga: View memory command:

image

I've also implemented a new panel to list these alongside CPU registers when debugging.

image

@BartmanAbyss
Copy link
Owner

cool. can you support CustomSpecial.pth, CustomSpecial.ptl to combine pointer registers into one as in https://github.com/BartmanAbyss/vscode-amiga-debug/blob/master/src/client/debugger/customregs.tsx#L84 ?

@grahambates
Copy link
Contributor Author

I've made this change and also refactored a bit to move a bit more logic into the BaseNode class to eliminate some repetition around value formatting etc.

@grahambates
Copy link
Contributor Author

We could definitely make more use of the tree view to group related fields and extract bit components from register values. I implemented something similar on The Other Extension 🙂:

image

I can look at porting this if you're interested (maybe as a separate PR). It's a bit of a different implementation because we use the variables list for registers, but I can definitely reuse the grouping logic. I'm guessing we'd want it in the profiler register list too.

@BartmanAbyss
Copy link
Owner

BartmanAbyss commented Nov 8, 2022

sure. that sounds fine. I'm doing something similar but more hard-coded for the DMA/blitter tooltips and the screen tooltips.
probably a bit harder for the profiler register list because I had to switch to a virtual list due to performance reasons, Maybe it's easier there to just add it to the tooltip.

@BartmanAbyss BartmanAbyss merged commit 34b9e7f into BartmanAbyss:master Nov 8, 2022
@grahambates grahambates deleted the custom_mem_read branch November 13, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants