Track source from profile disassembly view #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BartmanAbyss are you unsure about this change or do you just need time to review and test? Let me know if there's anything I can do or if you want to discuss. I'm aware that I'm bombarding you with PRs at the moment and I hope you're ok with this! I've just been pushing fixes and improvements as they've come up while using the extension and I've been aiming to provide working solutions rather than raising issues that create work for you. Is this the best way to collaborate or would you prefer some more upfront discussion? |
BartmanAbyss
approved these changes
Nov 13, 2022
|
It's all good. Was just a little busy this week and wanted to test this PR first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a mode in the profiler to enable following the timeline position in source files as well as disassembly. It's similar to how it works in the objdump editor when you disassemble an elf file. When this mode is enabled, scrubbing the timeline position on the flame graph will scroll through source locations in the right hand editor. This is similar to what @rjobling proposed in issue #99.
I've also added a toggle for the register overlay in the disassembly tab using the same UI pattern. I thought it was useful to be able to disable this when it's obscuring the disassembly content.