Emulator config improvements #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds NTSC option - Passes FS-UAE options as args. It doesn't really make sense to generate a config file because unlike WinUAE, FS-UAE doesn't have a UI to edit settings at runtime, so this never gets updated. - Adds `emuargs` option to pass additional CLI args to the emulator. Short of mirroring every available FS-UAE option in the debug launch request schema, this is really the only good way to have full control over options. You could use this to pass in custom options or the location of an externally created config file.
BartmanAbyss
reviewed
Feb 2, 2023
| @@ -537,7 +541,6 @@ export class AmigaDebugSession extends LoggingDebugSession { | |||
| const env = { | |||
| ...process.env, | |||
| LD_LIBRARY_PATH: ".", // Allow Linux fs-uae to find bundled .so files | |||
| DYLD_FALLBACK_LIBRARY_PATH: ".", // Allow Mac fs-uae to find bundled .dylib files | |||
There was a problem hiding this comment.
is this no longer needed on mac?
There was a problem hiding this comment.
No, the CI script now modifies the binary to reference the lib on a relative path.
| ? [ '-portable' ] | ||
| // FS-UAE options as args | ||
| : [...config].map(([k, v]) => `--${k}=${v}`)), | ||
| ...args.emuargs |
There was a problem hiding this comment.
This line causes TypeError: args.emuargs is not iterable when no emuargs are specified, thus breaking debugging for everyone in 1.7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ntscoptionemuargsoption to pass additional CLI args to the emulator. Short of mirroring every available FS-UAE option in the debug launch request schema, this is really the only good way to have full control over options. You could use this to pass in custom options or the location of an externally created config file.