Change postal code calculation #369
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FLoreauIGN
force-pushed
the
feat/add-meta-calculation
branch
from
36d05be
to
05505a1
Compare
| import {District} from '../../util/sequelize.js' | ||
|
|
||
| export const getDistrict = districtID => District.findByPk(districtID, {raw: true}) | ||
|
|
||
| export const getDistricts = districtIDs => District.findAll({where: {id: districtIDs}, raw: true}) | ||
|
|
||
| export const getDistrictsFromCog = cog => District.findAll({where: {meta: {insee: {cog}}}, raw: true}) | ||
| export const getDistrictFromCog = cog => District.findAll({where: {meta: {insee: {cog}}}, raw: true}) |
There was a problem hiding this comment.
Suggested change
| export const getDistrictFromCog = cog => District.findAll({where: {meta: {insee: {cog}}}, raw: true}) | |
| export const getDistrictsFromCog = cog => District.findAll({where: {meta: {insee: {cog}}}, raw: true}) |
| export const getDistrictsFromCog = cog => District.findAll({where: {meta: {insee: {cog}}}, raw: true}) | ||
| export const getDistrictFromCog = cog => District.findAll({where: {meta: {insee: {cog}}}, raw: true}) | ||
|
|
||
| export const getDistrictsFromCog = async cogList => { |
There was a problem hiding this comment.
Suggested change
| export const getDistrictsFromCog = async cogList => { | |
| export const getDistrictsFromCogList = async cogList => { |
| @@ -189,7 +190,7 @@ app.get('/cog/:cog', analyticsMiddleware, async (req, res) => { | |||
| let response | |||
| try { | |||
| const {cog} = req.params | |||
| const districts = await getDistrictsFromCog(cog) | |||
| const districts = await getDistrictFromCog(cog) | |||
There was a problem hiding this comment.
Suggested change
| const districts = await getDistrictFromCog(cog) | |
| const districts = await getDistrictsFromCog(cog) |
|
Il faudrait aussi renommer le fichier de migration de .js en .cjs |
| await apiQueue.add( | ||
| {dataType: 'district', jobType: 'updatePostalCode', data: postalFile, statusID}, | ||
| {jobId: statusID, removeOnComplete: true} | ||
| ) |
There was a problem hiding this comment.
Suggested change
| ) | |
| ) | |
| response = { | |
| date: new Date(), | |
| status: 'success', | |
| message: `Check the status of your request : ${BAN_API_URL}/job-status/${statusID}`, | |
| response: {statusID}, | |
| } |
|
Note : penser à modifier la fonction "extractRelatedDistrictIDs" du fichier api-consumer.js. Comportement à discuter. |
| // On February 2024 the postal file url is : | ||
| // https://datanova.laposte.fr/data-fair/api/v1/datasets/laposte-hexasmal/raw | ||
| const {url} = req.query | ||
| const postalFile = await fetch(url) |
There was a problem hiding this comment.
Suggested change
| const postalFile = await fetch(url) | |
| const postalFileRawResponse = await fetch(url) | |
| const postalFile = await postalFileRawResponse.text() |
| @@ -215,4 +216,59 @@ app.get('/cog/:cog', analyticsMiddleware, async (req, res) => { | |||
| res.send(response) | |||
| }) | |||
|
|
|||
| app.route('/codePostal', auth) | |||
There was a problem hiding this comment.
Quand je test avec l'URL GET /district/codePostal, "express" considère que "codePostal" est un UUID et que je j'essaye de récupérer les infos d'un district.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR vise à améliorer le calcul des codes postaux dans la base postgres à l'aide de données fournies par La Poste :
Pour cela, cette PR ajoute :
fix intégrer les données CP de datanova - migration #363