Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled setting auto exit full screen when playback completes on iOS … #826

Closed
wants to merge 1 commit into from
Closed

Enabled setting auto exit full screen when playback completes on iOS … #826

wants to merge 1 commit into from

Conversation

jamsoft
Copy link
Contributor

@jamsoft jamsoft commented Jul 14, 2021

…cannot find equal functionality on Android in order to implement.

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

When video playback on iOS is in full screen mode and the media item completes, the view is auto switched to normal inline view. Without closing full screen first any navigation will fail to actually navigate

⤵️ What is the current behavior?

Full screen prevents navigation

🆕 What is the new behavior (if this is a feature change)?

Full screen closes at the end of the media item.

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

Try setting the value in XAML on VideoView and play full screen video with the MediaItemComplete event handler performing a navigation.

📝 Links to relevant issues/docs

n/a

🤔 Checklist before submitting

  • [x ] All projects build
  • [ x] Follows style guide lines
  • Relevant documentation was updated
  • Rebased onto current develop

@martijn00
Copy link
Member

Hmm not sure this is a good way to solve this. Can't you add it as a static on the renderer only for iOS? The current code isn't even implemented properly for Forms...

@martijn00 martijn00 closed this Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants