platform: Correctly handle integer-like numbers from JSON #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In JSON, an allowed representation for doubles without a fractional part like `1.0` is actually `1`. This is, for example, the behavior of [JSONEncoder][1]. When using `jsonDecode`, a `0` or `1` is deserialized to an `int`, which would then cause `Position.fromMap` to crash. Instead, use `toDouble()` to ensure that the value is converted to a `double`. [1]: https://developer.apple.com/documentation/foundation/jsonencoder
|
Thanks, appreciate the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JSON, an allowed representation for doubles without a fractional part like
1.0is actually1. This is, for example, the behavior of JSONEncoder.When using
jsonDecode, a0or1is deserialized to anint, which would then causePosition.fromMapto crash. Instead, usetoDouble()to ensure that the value is converted to adouble.Pre-launch Checklist
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.mdto add a description of the change.///).main.dart format .and committed any changes.flutter analyzeand fixed any errors.