Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: permission_handler_apple has an incorrect privacy manifest #1292

Closed
3 of 5 tasks
stuartmorgan opened this issue Mar 20, 2024 · 2 comments · Fixed by #1293
Closed
3 of 5 tasks

[Bug]: permission_handler_apple has an incorrect privacy manifest #1292

stuartmorgan opened this issue Mar 20, 2024 · 2 comments · Fixed by #1293
Assignees
@mvanbeusekom
Labels
P1 High-priority issues at the top of the work list. platform: ios Issue is related to the iOS platform type: bug Something isn't working

Comments

@stuartmorgan
Copy link

Please check the following before submitting a new issue.

Please select affected platform(s)

  • Android
  • iOS
  • Windows

Steps to reproduce

  1. Look at

    flutter-permission-handler/permission_handler_apple/ios/Classes/strategies/LocationPermissionStrategy.m

    Line 45 in 3be556e

    BOOL alreadyRequested = [[NSUserDefaults standardUserDefaults] boolForKey:UserDefaultPermissionRequestedKey]; // check if already requested the permantent permission
    and see the use of NSUserDefaults
  2. Look at https://github.com/Baseflow/flutter-permission-handler/blob/3be556e67d52f73b1c072ad2334cd9b64196737f/permission_handler_apple/ios/Resources/PrivacyInfo.xcprivacy and see the lack of corresponding required reason entry.

Any plugin that uses a required reason API needs to declare it.

(I have not done a comprehensive audit; there may be other missing required reason API declarations as well. I'm filing this as I find it.)

Expected results

Privacy manifest that includes explanations of all Required Reason APIs

Actual results

Missing declaration

Code sample

N/A

Screenshots or video

No response

Version

current master

Flutter Doctor output

N/A
This was referenced Mar 20, 2024
Merged
Closed
Open
@jmagman
Copy link

jmagman commented Mar 20, 2024

cc @mvanbeusekom

@mvanbeusekom mvanbeusekom mentioned this issue Mar 21, 2024
Merged
10 tasks
@mvanbeusekom mvanbeusekom self-assigned this Mar 21, 2024
@mvanbeusekom mvanbeusekom added platform: ios Issue is related to the iOS platform type: bug Something isn't working P1 High-priority issues at the top of the work list. labels Mar 21, 2024
@mvanbeusekom
Copy link
Member

Hi @stuartmorgan,

Thanks for pointing this out, I missed the use of NSUserDefaults completely. We have just released an update containing the required privacy declaration.

confiks pushed a commit to MinBZK/nl-wallet that referenced this issue Apr 23, 2024
@pantsforcats
Update Flutter permission_handler_apple dependency
b45f0eb 
This should add a privacy manifest to the iOS build for the
NSPrivacyAccessedAPICategoryUserDefaults category.

See: Baseflow/flutter-permission-handler#1292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvanbeusekom mvanbeusekom

Labels
P1 High-priority issues at the top of the work list. platform: ios Issue is related to the iOS platform type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the use of NSUserDefaults to privacy manifest. Baseflow/flutter-permission-handler
3 participants
@stuartmorgan @jmagman @mvanbeusekom