Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 793 #794

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Issue 793 #794

merged 2 commits into from
Feb 17, 2022

Conversation

emarwil-cr
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

This change fixes the regression described in Issue #793

⤵️ What is the current behavior?

Current behavior prevents Android 9 (Pie) or earlier from having locationAlways permission granted due to a misplaced 'break' statement.

🆕 What is the new behavior (if this is a feature change)?

Behavior is restored to how it worked in v8.3.0 for Android 9 (Pie) and earlier.

💥 Does this PR introduce a breaking change?

No. Compared location permission behavior on Android 12 for both 9.0.1 and the current PR. Behavior is the same.

🐛 Recommendations for testing

Follow steps described in Issue #793 to confirm the behavior is now the same as it was in version 8.3.0 for location permissions.

📝 Links to relevant issues/docs

Issue #793: #793

🤔 Checklist before submitting

  • I made sure all projects build.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I followed the style guide lines (code style guide).
  • I updated the relevant documentation.
  • I rebased onto current master.

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #794 (faa5b45) into master (130ea81) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #794   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           16        16           
=========================================
  Hits            16        16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 130ea81...faa5b45. Read the comment docs.

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great catch, thanks for this contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants