Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support transparency #43

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mbfakourii
Copy link

@mbfakourii mbfakourii commented Jul 7, 2024

Add support transparency export (thanks @brendan-duncan in brendan-duncan/image#663).
Add support export base maximum frame size (thanks @brendan-duncan in brendan-duncan/image#664).
Improve example project base last flutter changes.

Closes: #27
Closes: #39

Pre-launch Checklist

  • I made sure the project builds.
  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

@mbfakourii mbfakourii changed the title feat: add transparency feat: add support transparency Jul 7, 2024
Copy link
Collaborator

@ueman ueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you!
Please also increase the version in the pubspec and add an entry to the changelog.md file.

pubspec.yaml Show resolved Hide resolved
lib/src/exporter.dart Outdated Show resolved Hide resolved
lib/src/exporter.dart Outdated Show resolved Hide resolved
@ueman
Copy link
Collaborator

ueman commented Jul 8, 2024

I can't release a new version, so that has to be done by Baseflow.

cc @mvanbeusekom @JeroenWeener @TimHoogstrate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Because every version of screen_recorder depends on image ^3.0.2 Support for transparency.
2 participants