Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean agnoster theme #1697

Merged
merged 3 commits into from
Jan 7, 2021
Merged

Conversation

NoahGorny
Copy link
Member

After #1694
Cleaning up agnoster theme, works after my cleanup

@cornfeedhobo
Copy link
Member

@NoahGorny If this PR is solely to format, I'll approve it, but this theme does a bunch of stuff that I don't like, so I'd love to get an associated cleanup. Check out my discussion thread, as it's related.

@NoahGorny
Copy link
Member Author

@NoahGorny If this PR is solely to format, I'll approve it, but this theme does a bunch of stuff that I don't like, so I'd love to get an associated cleanup. Check out my discussion thread, as it's related.

I see
I think that if we already lint the theme, it's worthwhile to change things we wanna change. However, this can be achieved in a following PR, as the diff will be hard to review here

@NoahGorny NoahGorny merged commit d97a36a into Bash-it:master Jan 7, 2021
@NoahGorny NoahGorny deleted the clean-agnoster-theme branch January 7, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants