Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plugin for basher #1759

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Conversation

cornfeedhobo
Copy link
Member

@cornfeedhobo cornfeedhobo commented Jan 1, 2021

Description

This PR seeks to add support for Basher.

Motivation and Context

We don't want to handle installing stuff, and I want a package manager for my bash stuffs (e.g. *env language tools).

Note: to implement full support for Basher, we'll need adjust the load priority of tools it would commonly manage, but after attempting a large PR to address that, I decided that breaking all the changes into separate PRs was a better plan.

How Has This Been Tested?

Locally, and it follows established conventions

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Left a couple of comments.

Happy new year 💐

plugins/available/basher.plugin.bash Show resolved Hide resolved
plugins/available/basher.plugin.bash Outdated Show resolved Hide resolved
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left you a couple of comments, but be sure I'll use your plugin in my setup soon enough 😄

plugins/available/basher.plugin.bash Outdated Show resolved Hide resolved
plugins/available/basher.plugin.bash Outdated Show resolved Hide resolved
plugins/available/basher.plugin.bash Show resolved Hide resolved
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will open up the needed issues today

@cornfeedhobo cornfeedhobo merged commit 3c00fe6 into Bash-it:master Jan 5, 2021
@cornfeedhobo cornfeedhobo deleted the add-basher-plugin branch February 3, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants