Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to newer versions of sdkman #1763

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

marcospereira
Copy link
Contributor

Description

The sdkman CLI added new commands, command aliases, and changed some output formats. This pull request adapts the completion script to support such changes. These were all tested using sdkman 5.9.1, but I suspect most of them were present in recent previous versions.

Motivation and Context

Properly support newer versions of sdkman.

How Has This Been Tested?

I've tested locally using sdkman 5.9.1 and with the following bash version:

GNU bash, version 5.1.0(1)-release (x86_64-apple-darwin20.1.0)
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Tested all the commands and validated that they are all working.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

It is a breaking change in the sense that older versions of sdkman won't work.

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Some new commands are available, and also aliases
for commands such as `i` for `install`.
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @marcospereira !
If you would like to lint the file as well as part of #1696 I would be delighted, but do not feel pressured to do so 😄

@NoahGorny NoahGorny merged commit c5f02b7 into Bash-it:master Jan 7, 2021
@marcospereira
Copy link
Contributor Author

Hey @NoahGorny, see #1775.

@marcospereira marcospereira deleted the sdkman-update branch January 8, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants