Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added alias for xclip command #1773

Merged
merged 3 commits into from
Jan 16, 2021
Merged

Conversation

tbhaxor
Copy link
Contributor

@tbhaxor tbhaxor commented Jan 8, 2021

Description

Added shortcut for xclip commands

Motivation and Context

The complete command is lengthy

How Has This Been Tested?

Check screenshots

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

aliases/available/xlicp.aliases.bash Outdated Show resolved Hide resolved
aliases/available/xlicp.aliases.bash Outdated Show resolved Hide resolved
aliases/available/xlicp.aliases.bash Outdated Show resolved Hide resolved
@NoahGorny
Copy link
Member

Hi @tbhaxor, thanks for contributing!
I think xclip is managed the the clipboard alias file. If you want, you can clean up the file and add new aliases of your choice, also, linting the existing alias file would be great!

@tbhaxor
Copy link
Contributor Author

tbhaxor commented Jan 8, 2021

Hi @tbhaxor, thanks for contributing!
I think xclip is managed the the clipboard alias file. If you want, you can clean up the file and add new aliases of your choice, also, linting the existing alias file would be great!

And you want separate PR for that :P

@NoahGorny
Copy link
Member

Hi @tbhaxor, thanks for contributing!
I think xclip is managed the the clipboard alias file. If you want, you can clean up the file and add new aliases of your choice, also, linting the existing alias file would be great!

And you want separate PR for that :P

I just don't think we need a new file, you can modify the existing one, and if you want, create a follow up PR with cleanup 😄

tbhaxor added a commit to tbhaxor/bash-it that referenced this pull request Jan 8, 2021
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its ready, @tbhaxor @davidpfarrell you can take another look if you want

@NoahGorny NoahGorny merged commit 988e966 into Bash-it:master Jan 16, 2021
@tbhaxor tbhaxor deleted the feature/clipboard-copy branch January 23, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants