docker-machine: Deprecate both plugin and completion file #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwinkler
reviewed
Jan 11, 2021
|
|
||
| complete -F _docker_machine docker-machine docker-machine.exe | ||
| # shellcheck shell=bash | ||
| _log_error '"docker-machine" is now deprecated, and as such the bash completion for it is also deprecated. |
There was a problem hiding this comment.
Don't know if we discussed this before, but do we want to raise the deprecation as an error? Wouldn't a warning be sufficient?
There was a problem hiding this comment.
Hmm, I am unsure. I think errors are things that should be reported to us, while warning are warnings to the user, so I guess this really should just be log_warning. I say we merge this, and I will open an issue about it
There was a problem hiding this comment.
I think we both agree that it should be a warning then?
There was a problem hiding this comment.
I updated the PR with a commit that changes all places like this
NoahGorny
force-pushed
the
deprecate-docker-machine
branch
from
99ce487
to
22ccff5
Compare
cornfeedhobo
approved these changes
Jan 29, 2021
added 2 commits
January 29, 2021 16:06
Deprecated component is not an error, but instead should be a warning to the user
NoahGorny
force-pushed
the
deprecate-docker-machine
branch
from
22ccff5
to
e8dc0f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1744
Closes #1786
Description
Deprecate both plugin and completion file of docker-machine, as the command is deprecated as well.
Motivation and Context
See #1744 for context
How Has This Been Tested?
enabled locally, saw the error log
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.