Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean atomic and axin theme #1783

Merged
merged 4 commits into from
Jan 14, 2021

Conversation

BarbUk
Copy link
Contributor

@BarbUk BarbUk commented Jan 11, 2021

Description

  • axin theme was just linted
  • atomic theme needed an update of the args parsing in internal function to be compliant with shellcheck:
args=($1)

become

read -r -a args <<< "$@"

Motivation and Context

#1696

How Has This Been Tested?

Tested both theme by using before and after the update

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work great, thank you @BarbUk!
This just needs a rebase, otherwise LGTM

@NoahGorny NoahGorny merged commit 5e667ed into Bash-it:master Jan 14, 2021
@NoahGorny
Copy link
Member

Thanks @BarbUk! Well done 😄

@BarbUk BarbUk deleted the clean/theme_atomic_and_axin branch January 14, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants